✨ Update progress on GamemasterExplorer refactoring with new composable extraction and additional tests
This commit is contained in:
@@ -121,7 +121,7 @@ Last Updated: January 28, 2026
|
|||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
## Phase 5: GamemasterExplorer Refactoring (1/9 complete)
|
## Phase 5: GamemasterExplorer Refactoring (2/9 complete)
|
||||||
**Duration**: 5-7 days
|
**Duration**: 5-7 days
|
||||||
**Status**: In Progress
|
**Status**: In Progress
|
||||||
**Target**: Reduce from 1627 lines → ~400 lines (76% reduction)
|
**Target**: Reduce from 1627 lines → ~400 lines (76% reduction)
|
||||||
@@ -132,12 +132,19 @@ Last Updated: January 28, 2026
|
|||||||
- [x] Extract search methods (executeSearch, clearSearch, goToNextResult, goToPrevResult)
|
- [x] Extract search methods (executeSearch, clearSearch, goToNextResult, goToPrevResult)
|
||||||
- [x] Support regex patterns and fallback synchronous search
|
- [x] Support regex patterns and fallback synchronous search
|
||||||
- [x] Write comprehensive tests - 35 tests passing ✅
|
- [x] Write comprehensive tests - 35 tests passing ✅
|
||||||
- Initialization and state management
|
|
||||||
- Search navigation (next/prev with wrapping)
|
### ✅ Step 14: Extract useGamemasterFiles Composable
|
||||||
- Text highlighting with regex escaping
|
- [x] Create `src/composables/useGamemasterFiles.js` - Full file loading & management
|
||||||
- Computed properties (currentResultLineNumber, resultCountDisplay, hasSearchResults)
|
- [x] Extract file state (selectedFile, fileContent, fileLines, displayLines)
|
||||||
- Error handling and cleanup
|
- [x] Extract file methods (loadStatus, loadFile, clearFileSelection, updateDisplayLines)
|
||||||
- History integration
|
- [x] Support pagination and virtual scrolling preparation
|
||||||
|
- [x] Write comprehensive tests - 45 tests passing ✅
|
||||||
|
- File loading for all types (pokemon, moves, allForms, raw)
|
||||||
|
- File size validation (50MB limit for raw files)
|
||||||
|
- Display line pagination (10K lines initially)
|
||||||
|
- Preference persistence
|
||||||
|
- JSON path extraction for filtering
|
||||||
|
- Error handling and state management
|
||||||
|
|
||||||
### ⏳ Step 14: Extract useGamemasterFiles Composable
|
### ⏳ Step 14: Extract useGamemasterFiles Composable
|
||||||
- [ ] Create `src/composables/useGamemasterFiles.js`
|
- [ ] Create `src/composables/useGamemasterFiles.js`
|
||||||
|
|||||||
Reference in New Issue
Block a user