From b0ad499b7e557f6fc98e1a04102ad89bda236350 Mon Sep 17 00:00:00 2001 From: FragginWagon Date: Thu, 29 Jan 2026 03:26:20 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=AA=20Simplify=20and=20improve=20test?= =?UTF-8?q?=20cases=20for=20`expandDisplayLinesToInclude`=20in=20`useGamem?= =?UTF-8?q?asterFiles`=20composable?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../composables/useGamemasterFiles.test.js | 29 +++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/code/websites/pokedex.online/tests/unit/composables/useGamemasterFiles.test.js b/code/websites/pokedex.online/tests/unit/composables/useGamemasterFiles.test.js index 5bf62c2..c06b66f 100644 --- a/code/websites/pokedex.online/tests/unit/composables/useGamemasterFiles.test.js +++ b/code/websites/pokedex.online/tests/unit/composables/useGamemasterFiles.test.js @@ -359,34 +359,27 @@ describe('useGamemasterFiles', () => { }); describe('expandDisplayLinesToInclude', () => { - beforeEach(async () => { - // Create large file with many items that will create many lines - const largeData = { - items: Array(15000).fill({ id: 1, data: 'test' }) - }; - mockClient.getPokemon.mockResolvedValueOnce(largeData); - composable.selectedFile.value = 'pokemon'; - await composable.loadFile(); - }); - it('should not expand if line is visible', () => { + composable.fileLines.value = Array(500).fill('line'); + composable.updateDisplayLines(0, 100); const originalLength = composable.displayLines.value.length; - composable.expandDisplayLinesToInclude(100); + + composable.expandDisplayLinesToInclude(50); expect(composable.displayLines.value.length).toBe(originalLength); }); - it('should expand to include line number', () => { - if (composable.fileLines.value.length > 15000) { - composable.expandDisplayLinesToInclude(15000); + it('should expand to include requested line', () => { + composable.fileLines.value = Array(500).fill('line'); + composable.updateDisplayLines(0, 100); - expect(composable.displayLines.value.length).toBeGreaterThan( - composable.LINES_TO_DISPLAY - ); - } + composable.expandDisplayLinesToInclude(300); + + expect(composable.displayLines.value.length).toBeGreaterThan(100); }); it('should not exceed total file lines', () => { + composable.fileLines.value = Array(500).fill('line'); composable.expandDisplayLinesToInclude(999999); expect(composable.displayLines.value.length).toBeLessThanOrEqual(