Refactor authentication handling and improve API client security
- Updated OAuth endpoints for Challonge and Discord in platforms configuration. - Implemented session and CSRF cookie initialization in main application entry. - Enhanced Challonge API client to avoid sending sensitive API keys from the browser. - Modified tournament querying to handle new state definitions and improved error handling. - Updated UI components to reflect server-side storage of authentication tokens. - Improved user experience in API Key Manager and Authentication Hub with clearer messaging. - Refactored client credentials management to support asynchronous operations. - Adjusted API client tests to validate new request configurations. - Updated Vite configuration to support session and CSRF handling through proxies.
This commit is contained in:
253
code/websites/pokedex.online/server/routes/challonge.js
Normal file
253
code/websites/pokedex.online/server/routes/challonge.js
Normal file
@@ -0,0 +1,253 @@
|
||||
import express from 'express';
|
||||
import fetch from 'node-fetch';
|
||||
import logger from '../utils/logger.js';
|
||||
|
||||
function isExpired(expiresAt) {
|
||||
if (!expiresAt) return false;
|
||||
return Date.now() >= expiresAt - 30_000; // 30s buffer
|
||||
}
|
||||
|
||||
async function refreshUserOAuth({ config, refreshToken }) {
|
||||
const response = await fetch('https://api.challonge.com/oauth/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
grant_type: 'refresh_token',
|
||||
client_id: config.challonge.clientId,
|
||||
client_secret: config.challonge.clientSecret,
|
||||
refresh_token: refreshToken
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
const err = new Error('Challonge refresh failed');
|
||||
err.status = response.status;
|
||||
err.payload = payload;
|
||||
throw err;
|
||||
}
|
||||
|
||||
return payload;
|
||||
}
|
||||
|
||||
async function exchangeClientCredentials({ clientId, clientSecret, scope }) {
|
||||
const response = await fetch('https://api.challonge.com/oauth/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
grant_type: 'client_credentials',
|
||||
client_id: clientId,
|
||||
client_secret: clientSecret,
|
||||
...(scope ? { scope } : {})
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
const err = new Error('Challonge client_credentials exchange failed');
|
||||
err.status = response.status;
|
||||
err.payload = payload;
|
||||
throw err;
|
||||
}
|
||||
|
||||
return payload;
|
||||
}
|
||||
|
||||
function computeExpiresAt(expiresInSeconds) {
|
||||
const ttl = Number(expiresInSeconds || 0);
|
||||
if (!ttl || Number.isNaN(ttl)) return null;
|
||||
return Date.now() + ttl * 1000;
|
||||
}
|
||||
|
||||
export function createChallongeProxyRouter({ config, tokenStore }) {
|
||||
const router = express.Router();
|
||||
|
||||
// Proxy all Challonge requests through backend; auth is derived from SID-stored credentials.
|
||||
router.all('/*', async (req, res) => {
|
||||
try {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const challongeRecord = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
|
||||
// Determine upstream path relative to this router mount
|
||||
// This router is mounted at /challonge, so req.url starts with /v1/... or /v2.1/...
|
||||
const upstreamPath = req.url.replace(/^\/+/, '');
|
||||
const upstreamUrl = new URL(`https://api.challonge.com/${upstreamPath}`);
|
||||
|
||||
const authTypeRaw = req.header('Authorization-Type');
|
||||
const authType = authTypeRaw?.toLowerCase();
|
||||
const wantsApplication = upstreamPath.startsWith('v2.1/application/');
|
||||
|
||||
const isSafeMethod = req.method === 'GET' || req.method === 'HEAD';
|
||||
|
||||
// Build headers
|
||||
const headers = { ...req.headers };
|
||||
delete headers.host;
|
||||
delete headers.connection;
|
||||
delete headers['content-length'];
|
||||
|
||||
// Normalize sensitive/auth headers (avoid duplicate casing like
|
||||
// 'authorization-type' + 'Authorization-Type' which can confuse upstream)
|
||||
delete headers.authorization;
|
||||
delete headers.Authorization;
|
||||
delete headers['authorization-type'];
|
||||
delete headers['Authorization-Type'];
|
||||
|
||||
// Apply auth based on request + stored credentials
|
||||
if (upstreamPath.startsWith('v1/')) {
|
||||
const apiKey = challongeRecord.api_key?.token;
|
||||
if (!apiKey) {
|
||||
return res.status(401).json({
|
||||
error: 'Challonge API key not configured for this session',
|
||||
code: 'CHALLONGE_API_KEY_REQUIRED'
|
||||
});
|
||||
}
|
||||
upstreamUrl.searchParams.set('api_key', apiKey);
|
||||
} else if (upstreamPath.startsWith('v2.1/')) {
|
||||
if (wantsApplication) {
|
||||
const app = challongeRecord.client_credentials;
|
||||
if (!app?.client_id || !app?.client_secret) {
|
||||
return res.status(401).json({
|
||||
error: 'Challonge client credentials not configured for this session',
|
||||
code: 'CHALLONGE_CLIENT_CREDENTIALS_REQUIRED'
|
||||
});
|
||||
}
|
||||
|
||||
let accessToken = app.access_token;
|
||||
if (!accessToken || isExpired(app.expires_at)) {
|
||||
const exchanged = await exchangeClientCredentials({
|
||||
clientId: app.client_id,
|
||||
clientSecret: app.client_secret,
|
||||
scope: app.scope
|
||||
});
|
||||
challongeRecord.client_credentials = {
|
||||
...app,
|
||||
access_token: exchanged.access_token,
|
||||
token_type: exchanged.token_type,
|
||||
scope: exchanged.scope,
|
||||
expires_at: computeExpiresAt(exchanged.expires_in)
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', challongeRecord);
|
||||
accessToken = challongeRecord.client_credentials.access_token;
|
||||
}
|
||||
|
||||
headers['authorization'] = `Bearer ${accessToken}`;
|
||||
headers['authorization-type'] = 'v2';
|
||||
} else if (authType === 'v1') {
|
||||
// v2.1 supports legacy API key via Authorization header + Authorization-Type: v1
|
||||
const apiKey = challongeRecord.api_key?.token;
|
||||
if (!apiKey) {
|
||||
return res.status(401).json({
|
||||
error: 'Challonge API key not configured for this session',
|
||||
code: 'CHALLONGE_API_KEY_REQUIRED'
|
||||
});
|
||||
}
|
||||
headers['authorization'] = apiKey;
|
||||
headers['authorization-type'] = 'v1';
|
||||
} else {
|
||||
// default to user OAuth (Bearer)
|
||||
const user = challongeRecord.user_oauth;
|
||||
if (!user?.access_token) {
|
||||
return res.status(401).json({
|
||||
error: 'Challonge OAuth not connected for this session',
|
||||
code: 'CHALLONGE_OAUTH_REQUIRED'
|
||||
});
|
||||
}
|
||||
|
||||
let accessToken = user.access_token;
|
||||
if (isExpired(user.expires_at) && user.refresh_token && config.challonge.configured) {
|
||||
try {
|
||||
const refreshed = await refreshUserOAuth({
|
||||
config,
|
||||
refreshToken: user.refresh_token
|
||||
});
|
||||
challongeRecord.user_oauth = {
|
||||
...user,
|
||||
access_token: refreshed.access_token,
|
||||
refresh_token: refreshed.refresh_token || user.refresh_token,
|
||||
token_type: refreshed.token_type,
|
||||
scope: refreshed.scope,
|
||||
expires_at: computeExpiresAt(refreshed.expires_in)
|
||||
};
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', challongeRecord);
|
||||
accessToken = challongeRecord.user_oauth.access_token;
|
||||
} catch (err) {
|
||||
logger.warn('Failed to refresh Challonge user OAuth token', {
|
||||
status: err.status,
|
||||
payload: err.payload
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
headers['authorization'] = `Bearer ${accessToken}`;
|
||||
headers['authorization-type'] = 'v2';
|
||||
}
|
||||
}
|
||||
|
||||
const fetchOptions = {
|
||||
method: req.method,
|
||||
headers
|
||||
};
|
||||
|
||||
if (req.method !== 'GET' && req.method !== 'HEAD') {
|
||||
if (req.body !== undefined && req.body !== null) {
|
||||
// express.json parsed it already
|
||||
fetchOptions.body = JSON.stringify(req.body);
|
||||
}
|
||||
}
|
||||
|
||||
let upstreamResponse = await fetch(upstreamUrl.toString(), fetchOptions);
|
||||
|
||||
// If user OAuth is present but invalid/revoked, the upstream may return 401/403.
|
||||
// For safe methods, fall back to the stored API key if available.
|
||||
// This helps avoid a confusing "connected" state that still can't query tournaments.
|
||||
if (
|
||||
isSafeMethod &&
|
||||
upstreamPath.startsWith('v2.1/') &&
|
||||
!wantsApplication &&
|
||||
authType !== 'v1' &&
|
||||
(upstreamResponse.status === 401 || upstreamResponse.status === 403)
|
||||
) {
|
||||
const apiKey = challongeRecord.api_key?.token;
|
||||
if (apiKey) {
|
||||
logger.warn('Challonge v2.1 user OAuth unauthorized; retrying with API key', {
|
||||
status: upstreamResponse.status,
|
||||
path: upstreamPath
|
||||
});
|
||||
|
||||
const retryHeaders = { ...headers };
|
||||
delete retryHeaders.authorization;
|
||||
delete retryHeaders.Authorization;
|
||||
delete retryHeaders['authorization-type'];
|
||||
delete retryHeaders['Authorization-Type'];
|
||||
retryHeaders['authorization'] = apiKey;
|
||||
retryHeaders['authorization-type'] = 'v1';
|
||||
|
||||
upstreamResponse = await fetch(upstreamUrl.toString(), {
|
||||
...fetchOptions,
|
||||
headers: retryHeaders
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// Forward status + headers (minimal)
|
||||
res.status(upstreamResponse.status);
|
||||
const contentType = upstreamResponse.headers.get('content-type');
|
||||
if (contentType) res.setHeader('content-type', contentType);
|
||||
|
||||
const buf = await upstreamResponse.arrayBuffer();
|
||||
return res.send(Buffer.from(buf));
|
||||
} catch (err) {
|
||||
logger.error('Challonge proxy error', { error: err.message });
|
||||
return res.status(502).json({
|
||||
error: 'Challonge proxy failed',
|
||||
code: 'CHALLONGE_PROXY_FAILED'
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
return router;
|
||||
}
|
||||
41
code/websites/pokedex.online/server/routes/discord.js
Normal file
41
code/websites/pokedex.online/server/routes/discord.js
Normal file
@@ -0,0 +1,41 @@
|
||||
import express from 'express';
|
||||
import fetch from 'node-fetch';
|
||||
|
||||
export function createDiscordRouter({ tokenStore }) {
|
||||
const router = express.Router();
|
||||
|
||||
router.get('/profile', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const record = await tokenStore.getProviderRecord(req.sid, 'discord');
|
||||
const accessToken = record?.access_token;
|
||||
if (!accessToken) {
|
||||
return res.status(401).json({
|
||||
error: 'Not connected to Discord',
|
||||
code: 'DISCORD_NOT_CONNECTED'
|
||||
});
|
||||
}
|
||||
|
||||
const response = await fetch('https://discord.com/api/users/@me', {
|
||||
headers: {
|
||||
Authorization: `Bearer ${accessToken}`
|
||||
}
|
||||
});
|
||||
|
||||
if (!response.ok) {
|
||||
const details = await response.text();
|
||||
return res.status(response.status).json({
|
||||
error: 'Failed to fetch Discord profile',
|
||||
code: 'DISCORD_PROFILE_FAILED',
|
||||
details: details.slice(0, 1000)
|
||||
});
|
||||
}
|
||||
|
||||
const user = await response.json();
|
||||
return res.json({ user });
|
||||
});
|
||||
|
||||
return router;
|
||||
}
|
||||
480
code/websites/pokedex.online/server/routes/oauth.js
Normal file
480
code/websites/pokedex.online/server/routes/oauth.js
Normal file
@@ -0,0 +1,480 @@
|
||||
import express from 'express';
|
||||
import fetch from 'node-fetch';
|
||||
import logger from '../utils/logger.js';
|
||||
|
||||
function computeExpiresAt(expiresInSeconds) {
|
||||
const ttl = Number(expiresInSeconds || 0);
|
||||
if (!ttl || Number.isNaN(ttl)) return null;
|
||||
return Date.now() + ttl * 1000;
|
||||
}
|
||||
|
||||
function redactProviderRecord(provider, record) {
|
||||
if (!record) {
|
||||
if (provider === 'challonge') {
|
||||
return {
|
||||
provider,
|
||||
connected: false,
|
||||
methods: {
|
||||
user_oauth: {
|
||||
connected: false,
|
||||
expires_at: null,
|
||||
scope: null
|
||||
},
|
||||
client_credentials: {
|
||||
stored: false,
|
||||
connected: false,
|
||||
expires_at: null,
|
||||
scope: null
|
||||
},
|
||||
api_key: {
|
||||
stored: false,
|
||||
connected: false
|
||||
}
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
if (provider === 'discord') {
|
||||
return {
|
||||
provider,
|
||||
connected: false,
|
||||
expires_at: null,
|
||||
scope: null
|
||||
};
|
||||
}
|
||||
|
||||
return { provider, connected: false };
|
||||
}
|
||||
|
||||
if (provider === 'discord') {
|
||||
return {
|
||||
provider,
|
||||
connected: !!record.access_token,
|
||||
expires_at: record.expires_at || null,
|
||||
scope: record.scope || null
|
||||
};
|
||||
}
|
||||
|
||||
if (provider === 'challonge') {
|
||||
const user = record.user_oauth;
|
||||
const app = record.client_credentials;
|
||||
const apiKey = record.api_key;
|
||||
|
||||
return {
|
||||
provider,
|
||||
connected: !!(user?.access_token || app?.access_token || apiKey?.token),
|
||||
methods: {
|
||||
user_oauth: {
|
||||
connected: !!user?.access_token,
|
||||
expires_at: user?.expires_at || null,
|
||||
scope: user?.scope || null
|
||||
},
|
||||
client_credentials: {
|
||||
stored: !!(app?.client_id && app?.client_secret),
|
||||
connected: !!app?.access_token,
|
||||
expires_at: app?.expires_at || null,
|
||||
scope: app?.scope || null
|
||||
},
|
||||
api_key: {
|
||||
stored: !!apiKey?.token,
|
||||
connected: !!apiKey?.token
|
||||
}
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
return { provider, connected: true };
|
||||
}
|
||||
|
||||
export function createOAuthRouter({ config, tokenStore }) {
|
||||
const router = express.Router();
|
||||
|
||||
router.get('/:provider/status', async (req, res) => {
|
||||
const { provider } = req.params;
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const record = await tokenStore.getProviderRecord(req.sid, provider);
|
||||
return res.json(redactProviderRecord(provider, record));
|
||||
});
|
||||
|
||||
router.post('/:provider/disconnect', async (req, res) => {
|
||||
const { provider } = req.params;
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
await tokenStore.deleteProviderRecord(req.sid, provider);
|
||||
return res.json({ ok: true });
|
||||
});
|
||||
|
||||
// Exchange authorization code (server stores tokens; frontend never receives them)
|
||||
router.post('/:provider/exchange', async (req, res) => {
|
||||
const { provider } = req.params;
|
||||
const { code } = req.body || {};
|
||||
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
if (!code) {
|
||||
return res.status(400).json({ error: 'Authorization code is required', code: 'MISSING_CODE' });
|
||||
}
|
||||
|
||||
if (provider === 'discord') {
|
||||
const clientId = process.env.VITE_DISCORD_CLIENT_ID;
|
||||
const clientSecret = process.env.DISCORD_CLIENT_SECRET;
|
||||
const redirectUri = process.env.DISCORD_REDIRECT_URI || process.env.VITE_DISCORD_REDIRECT_URI;
|
||||
|
||||
if (!clientId || !clientSecret || !redirectUri) {
|
||||
return res.status(503).json({
|
||||
error: 'Discord OAuth not configured',
|
||||
code: 'DISCORD_NOT_CONFIGURED'
|
||||
});
|
||||
}
|
||||
|
||||
const response = await fetch('https://discord.com/api/oauth2/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
client_id: clientId,
|
||||
client_secret: clientSecret,
|
||||
grant_type: 'authorization_code',
|
||||
code,
|
||||
redirect_uri: redirectUri
|
||||
})
|
||||
});
|
||||
|
||||
const text = await response.text();
|
||||
let payload;
|
||||
try {
|
||||
payload = text ? JSON.parse(text) : {};
|
||||
} catch {
|
||||
payload = { raw: text.slice(0, 1000) };
|
||||
}
|
||||
|
||||
if (!response.ok) {
|
||||
logger.warn('Discord token exchange failed', { status: response.status, payload });
|
||||
return res.status(response.status).json({
|
||||
error: 'Discord token exchange failed',
|
||||
code: 'DISCORD_TOKEN_EXCHANGE_FAILED',
|
||||
details: payload
|
||||
});
|
||||
}
|
||||
|
||||
const record = {
|
||||
access_token: payload.access_token,
|
||||
refresh_token: payload.refresh_token,
|
||||
token_type: payload.token_type,
|
||||
scope: payload.scope,
|
||||
expires_at: computeExpiresAt(payload.expires_in)
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'discord', record);
|
||||
return res.json(redactProviderRecord('discord', record));
|
||||
}
|
||||
|
||||
if (provider === 'challonge') {
|
||||
if (!config.challonge.configured || !config.challonge.redirectUri) {
|
||||
return res.status(503).json({
|
||||
error: 'Challonge OAuth not configured',
|
||||
code: 'CHALLONGE_NOT_CONFIGURED'
|
||||
});
|
||||
}
|
||||
|
||||
const response = await fetch('https://api.challonge.com/oauth/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
grant_type: 'authorization_code',
|
||||
client_id: config.challonge.clientId,
|
||||
client_secret: config.challonge.clientSecret,
|
||||
code,
|
||||
redirect_uri: config.challonge.redirectUri
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
logger.warn('Challonge token exchange failed', { status: response.status, payload });
|
||||
return res.status(response.status).json({
|
||||
error: 'Challonge token exchange failed',
|
||||
code: 'CHALLONGE_TOKEN_EXCHANGE_FAILED',
|
||||
details: payload
|
||||
});
|
||||
}
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const user_oauth = {
|
||||
access_token: payload.access_token,
|
||||
refresh_token: payload.refresh_token,
|
||||
token_type: payload.token_type,
|
||||
scope: payload.scope,
|
||||
expires_at: computeExpiresAt(payload.expires_in)
|
||||
};
|
||||
|
||||
const record = {
|
||||
...existing,
|
||||
user_oauth
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
}
|
||||
|
||||
return res.status(400).json({ error: `Unknown provider: ${provider}`, code: 'UNKNOWN_PROVIDER' });
|
||||
});
|
||||
|
||||
// Store Challonge API key (v1 compatibility) per session
|
||||
router.post('/challonge/api-key', async (req, res) => {
|
||||
let { apiKey } = req.body || {};
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
if (!apiKey) {
|
||||
return res.status(400).json({ error: 'apiKey is required', code: 'MISSING_API_KEY' });
|
||||
}
|
||||
|
||||
apiKey = String(apiKey).trim();
|
||||
if (apiKey.toLowerCase().startsWith('bearer ')) {
|
||||
apiKey = apiKey.slice('bearer '.length).trim();
|
||||
}
|
||||
if (!apiKey) {
|
||||
return res.status(400).json({ error: 'apiKey is required', code: 'MISSING_API_KEY' });
|
||||
}
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const record = {
|
||||
...existing,
|
||||
api_key: {
|
||||
token: apiKey
|
||||
}
|
||||
};
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
});
|
||||
|
||||
router.post('/challonge/api-key/clear', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const record = { ...existing };
|
||||
if (record.api_key) delete record.api_key;
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
});
|
||||
|
||||
// Store Challonge client credentials and exchange token per session
|
||||
router.post('/challonge/client-credentials', async (req, res) => {
|
||||
let { clientId, clientSecret, scope } = req.body || {};
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
if (typeof clientId === 'string') clientId = clientId.trim();
|
||||
if (typeof clientSecret === 'string') clientSecret = clientSecret.trim();
|
||||
if (typeof scope === 'string') scope = scope.trim();
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const prev = existing.client_credentials || {};
|
||||
const effectiveClientId = clientId || prev.client_id;
|
||||
const effectiveClientSecret = clientSecret || prev.client_secret;
|
||||
const effectiveScope = scope || prev.scope;
|
||||
|
||||
if (!effectiveClientId || !effectiveClientSecret) {
|
||||
return res.status(400).json({
|
||||
error: 'clientId and clientSecret are required (or must already be stored for this session)',
|
||||
code: 'MISSING_CLIENT_CREDENTIALS'
|
||||
});
|
||||
}
|
||||
|
||||
const response = await fetch('https://api.challonge.com/oauth/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
grant_type: 'client_credentials',
|
||||
client_id: effectiveClientId,
|
||||
client_secret: effectiveClientSecret,
|
||||
...(effectiveScope ? { scope: effectiveScope } : {})
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
logger.warn('Challonge client_credentials token exchange failed', { status: response.status, payload });
|
||||
return res.status(response.status).json({
|
||||
error: 'Challonge client credentials exchange failed',
|
||||
code: 'CHALLONGE_CLIENT_CREDENTIALS_FAILED',
|
||||
details: payload
|
||||
});
|
||||
}
|
||||
|
||||
const record = {
|
||||
...existing,
|
||||
client_credentials: {
|
||||
client_id: effectiveClientId,
|
||||
client_secret: effectiveClientSecret,
|
||||
access_token: payload.access_token,
|
||||
token_type: payload.token_type,
|
||||
scope: payload.scope,
|
||||
expires_at: computeExpiresAt(payload.expires_in)
|
||||
}
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
});
|
||||
|
||||
router.post('/challonge/client-credentials/clear', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const record = { ...existing };
|
||||
if (record.client_credentials) delete record.client_credentials;
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
});
|
||||
|
||||
// Logout client credentials token but retain stored client_id/client_secret
|
||||
router.post('/challonge/client-credentials/logout', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const existing = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
const creds = existing.client_credentials;
|
||||
if (!creds) {
|
||||
return res.json(redactProviderRecord('challonge', existing));
|
||||
}
|
||||
|
||||
const record = {
|
||||
...existing,
|
||||
client_credentials: {
|
||||
client_id: creds.client_id,
|
||||
client_secret: creds.client_secret
|
||||
}
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', record);
|
||||
return res.json(redactProviderRecord('challonge', record));
|
||||
});
|
||||
|
||||
// Refresh stored OAuth tokens (no tokens returned to browser)
|
||||
router.post('/:provider/refresh', async (req, res) => {
|
||||
const { provider } = req.params;
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const record = await tokenStore.getProviderRecord(req.sid, provider);
|
||||
if (!record) {
|
||||
return res.status(400).json({ error: 'No stored tokens', code: 'NO_TOKENS' });
|
||||
}
|
||||
|
||||
if (provider === 'discord') {
|
||||
const refreshToken = record.refresh_token;
|
||||
if (!refreshToken) {
|
||||
return res.status(400).json({ error: 'No refresh token available', code: 'NO_REFRESH_TOKEN' });
|
||||
}
|
||||
|
||||
const clientId = process.env.VITE_DISCORD_CLIENT_ID;
|
||||
const clientSecret = process.env.DISCORD_CLIENT_SECRET;
|
||||
if (!clientId || !clientSecret) {
|
||||
return res.status(503).json({ error: 'Discord OAuth not configured', code: 'DISCORD_NOT_CONFIGURED' });
|
||||
}
|
||||
|
||||
const response = await fetch('https://discord.com/api/oauth2/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
client_id: clientId,
|
||||
client_secret: clientSecret,
|
||||
grant_type: 'refresh_token',
|
||||
refresh_token: refreshToken
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
return res.status(response.status).json({
|
||||
error: 'Discord refresh failed',
|
||||
code: 'DISCORD_REFRESH_FAILED',
|
||||
details: payload
|
||||
});
|
||||
}
|
||||
|
||||
const updated = {
|
||||
...record,
|
||||
access_token: payload.access_token,
|
||||
refresh_token: payload.refresh_token || record.refresh_token,
|
||||
token_type: payload.token_type,
|
||||
scope: payload.scope,
|
||||
expires_at: computeExpiresAt(payload.expires_in)
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'discord', updated);
|
||||
return res.json(redactProviderRecord('discord', updated));
|
||||
}
|
||||
|
||||
if (provider === 'challonge') {
|
||||
const user = record.user_oauth;
|
||||
if (!user?.refresh_token) {
|
||||
return res.status(400).json({
|
||||
error: 'No refresh token available',
|
||||
code: 'NO_REFRESH_TOKEN'
|
||||
});
|
||||
}
|
||||
|
||||
if (!config.challonge.configured) {
|
||||
return res.status(503).json({
|
||||
error: 'Challonge OAuth not configured',
|
||||
code: 'CHALLONGE_NOT_CONFIGURED'
|
||||
});
|
||||
}
|
||||
|
||||
const response = await fetch('https://api.challonge.com/oauth/token', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
|
||||
body: new URLSearchParams({
|
||||
grant_type: 'refresh_token',
|
||||
client_id: config.challonge.clientId,
|
||||
client_secret: config.challonge.clientSecret,
|
||||
refresh_token: user.refresh_token
|
||||
})
|
||||
});
|
||||
|
||||
const payload = await response.json().catch(() => ({}));
|
||||
if (!response.ok) {
|
||||
return res.status(response.status).json({
|
||||
error: 'Challonge refresh failed',
|
||||
code: 'CHALLONGE_REFRESH_FAILED',
|
||||
details: payload
|
||||
});
|
||||
}
|
||||
|
||||
const updatedRecord = {
|
||||
...record,
|
||||
user_oauth: {
|
||||
...user,
|
||||
access_token: payload.access_token,
|
||||
refresh_token: payload.refresh_token || user.refresh_token,
|
||||
token_type: payload.token_type,
|
||||
scope: payload.scope,
|
||||
expires_at: computeExpiresAt(payload.expires_in)
|
||||
}
|
||||
};
|
||||
|
||||
await tokenStore.setProviderRecord(req.sid, 'challonge', updatedRecord);
|
||||
return res.json(redactProviderRecord('challonge', updatedRecord));
|
||||
}
|
||||
|
||||
return res.status(400).json({ error: `Unknown provider: ${provider}`, code: 'UNKNOWN_PROVIDER' });
|
||||
});
|
||||
|
||||
return router;
|
||||
}
|
||||
152
code/websites/pokedex.online/server/routes/session.js
Normal file
152
code/websites/pokedex.online/server/routes/session.js
Normal file
@@ -0,0 +1,152 @@
|
||||
import express from 'express';
|
||||
import fetch from 'node-fetch';
|
||||
import { COOKIE_NAMES, getCsrfCookieOptions, generateToken } from '../utils/cookie-options.js';
|
||||
|
||||
export function createSessionRouter({ config, tokenStore }) {
|
||||
const router = express.Router();
|
||||
|
||||
async function probeChallonge(url, headers) {
|
||||
try {
|
||||
const resp = await fetch(url, { method: 'GET', headers });
|
||||
const contentType = resp.headers.get('content-type') || '';
|
||||
let bodyText = '';
|
||||
try {
|
||||
bodyText = await resp.text();
|
||||
} catch {
|
||||
bodyText = '';
|
||||
}
|
||||
|
||||
// Keep response small & safe
|
||||
const snippet = (bodyText || '').slice(0, 500);
|
||||
let json = null;
|
||||
if (contentType.includes('application/json')) {
|
||||
try {
|
||||
json = bodyText ? JSON.parse(bodyText) : null;
|
||||
} catch {
|
||||
json = null;
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
ok: resp.ok,
|
||||
status: resp.status,
|
||||
contentType,
|
||||
snippet,
|
||||
json
|
||||
};
|
||||
} catch (err) {
|
||||
return {
|
||||
ok: false,
|
||||
status: null,
|
||||
contentType: null,
|
||||
snippet: err?.message || 'probe failed',
|
||||
json: null
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
// Ensure SID exists (sid middleware should run before this)
|
||||
router.get('/init', async (req, res) => {
|
||||
try {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
await tokenStore.touchSession(req.sid);
|
||||
return res.json({ ok: true });
|
||||
} catch (err) {
|
||||
return res.status(500).json({
|
||||
error: err.message || 'Failed to init session',
|
||||
code: 'SESSION_INIT_FAILED'
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
// Issue/refresh CSRF token cookie
|
||||
router.get('/csrf', (req, res) => {
|
||||
const token = generateToken(24);
|
||||
res.cookie(COOKIE_NAMES.csrf, token, getCsrfCookieOptions(config));
|
||||
res.json({ csrfToken: token });
|
||||
});
|
||||
|
||||
// Dev helper: confirm which SID the browser is using and whether provider
|
||||
// credentials are present for that SID. Does not return secrets.
|
||||
router.get('/whoami', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const challonge = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
|
||||
return res.json({
|
||||
sid: req.sid,
|
||||
challonge: {
|
||||
hasApiKey: !!challonge.api_key?.token,
|
||||
hasUserOAuth: !!challonge.user_oauth?.access_token,
|
||||
userOAuthExpiresAt: challonge.user_oauth?.expires_at || null,
|
||||
hasClientCredentials: !!(challonge.client_credentials?.client_id && challonge.client_credentials?.client_secret),
|
||||
hasClientCredentialsToken: !!challonge.client_credentials?.access_token,
|
||||
clientCredentialsExpiresAt: challonge.client_credentials?.expires_at || null
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
// Dev-only: verify challonge upstream auth for this SID (no secrets returned)
|
||||
router.get('/challonge/verify', async (req, res) => {
|
||||
if (!req.sid) {
|
||||
return res.status(500).json({ error: 'SID middleware not configured' });
|
||||
}
|
||||
|
||||
const challonge = (await tokenStore.getProviderRecord(req.sid, 'challonge')) || {};
|
||||
|
||||
const base = 'https://api.challonge.com/v2.1/tournaments.json?page=1&per_page=1&state=pending';
|
||||
const results = {
|
||||
sid: req.sid,
|
||||
endpoints: {
|
||||
userTournamentsSample: base,
|
||||
appTournamentsSample: 'https://api.challonge.com/v2.1/application/tournaments.json?page=1&per_page=1&state=pending'
|
||||
},
|
||||
methods: {
|
||||
user_oauth: { present: !!challonge.user_oauth?.access_token, probe: null },
|
||||
api_key: { present: !!challonge.api_key?.token, probe: null },
|
||||
client_credentials: {
|
||||
present: !!challonge.client_credentials?.access_token,
|
||||
probe: null
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
if (challonge.user_oauth?.access_token) {
|
||||
results.methods.user_oauth.probe = await probeChallonge(base, {
|
||||
Accept: 'application/json',
|
||||
'Content-Type': 'application/vnd.api+json',
|
||||
authorization: `Bearer ${challonge.user_oauth.access_token}`,
|
||||
'authorization-type': 'v2'
|
||||
});
|
||||
}
|
||||
|
||||
if (challonge.api_key?.token) {
|
||||
results.methods.api_key.probe = await probeChallonge(base, {
|
||||
Accept: 'application/json',
|
||||
'Content-Type': 'application/vnd.api+json',
|
||||
authorization: challonge.api_key.token,
|
||||
'authorization-type': 'v1'
|
||||
});
|
||||
}
|
||||
|
||||
if (challonge.client_credentials?.access_token) {
|
||||
results.methods.client_credentials.probe = await probeChallonge(
|
||||
results.endpoints.appTournamentsSample,
|
||||
{
|
||||
Accept: 'application/json',
|
||||
'Content-Type': 'application/vnd.api+json',
|
||||
authorization: `Bearer ${challonge.client_credentials.access_token}`,
|
||||
'authorization-type': 'v2'
|
||||
}
|
||||
);
|
||||
}
|
||||
|
||||
return res.json(results);
|
||||
});
|
||||
|
||||
return router;
|
||||
}
|
||||
Reference in New Issue
Block a user