From 4615fa0ef1f59d05cbe3431db9d4e8a41bf7f26b Mon Sep 17 00:00:00 2001
From: FragginWagon <greg.r.jacobs@gmail.com>
Date: Thu, 29 Jan 2026 13:18:46 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Improve=20code=20readability=20by?=
 =?UTF-8?q?=20reformatting=20and=20reindenting=20environment=20validation?=
 =?UTF-8?q?=20logic?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../server/utils/env-validator.js             | 72 ++++++++++++-------
 1 file changed, 45 insertions(+), 27 deletions(-)

diff --git a/code/websites/pokedex.online/server/utils/env-validator.js b/code/websites/pokedex.online/server/utils/env-validator.js
index 93862f7..c416b73 100644
--- a/code/websites/pokedex.online/server/utils/env-validator.js
+++ b/code/websites/pokedex.online/server/utils/env-validator.js
@@ -1,6 +1,6 @@
 /**
  * Environment Variable Validation
- * 
+ *
  * Validates required environment variables at startup and provides
  * helpful error messages for production deployments.
  */
@@ -13,26 +13,33 @@ const REQUIRED_ENV_VARS = {
   NODE_ENV: {
     required: true,
     description: 'Environment mode (development, production)',
-    validate: (val) => ['development', 'production', 'test'].includes(val)
+    validate: val => ['development', 'production', 'test'].includes(val)
   },
   PORT: {
     required: true,
     description: 'Server port number',
-    validate: (val) => !isNaN(parseInt(val)) && parseInt(val) > 0 && parseInt(val) < 65536
+    validate: val =>
+      !isNaN(parseInt(val)) && parseInt(val) > 0 && parseInt(val) < 65536
   },
-  
+
   // Optional but recommended for production
   SESSION_SECRET: {
     required: false,
     description: 'Secret key for session encryption',
-    warn: (val) => !val || val.length < 32 ? 'SESSION_SECRET should be at least 32 characters for security' : null
+    warn: val =>
+      !val || val.length < 32
+        ? 'SESSION_SECRET should be at least 32 characters for security'
+        : null
   },
   FRONTEND_URL: {
     required: false,
     description: 'Frontend URL for CORS (required in production)',
-    warn: (val, env) => env.NODE_ENV === 'production' && !val ? 'FRONTEND_URL should be set in production for proper CORS' : null
+    warn: (val, env) =>
+      env.NODE_ENV === 'production' && !val
+        ? 'FRONTEND_URL should be set in production for proper CORS'
+        : null
   },
-  
+
   // Challonge OAuth (optional)
   CHALLONGE_CLIENT_ID: {
     required: false,
@@ -56,23 +63,27 @@ export function validateEnvironment() {
   const errors = [];
   const warnings = [];
   const missing = [];
-  
+
   // Check required variables
   for (const [key, config] of Object.entries(REQUIRED_ENV_VARS)) {
     const value = process.env[key];
-    
+
     // Check if required variable is missing
     if (config.required && !value) {
-      errors.push(`Missing required environment variable: ${key} - ${config.description}`);
+      errors.push(
+        `Missing required environment variable: ${key} - ${config.description}`
+      );
       missing.push(key);
       continue;
     }
-    
+
     // Validate value if present
     if (value && config.validate && !config.validate(value)) {
-      errors.push(`Invalid value for ${key}: "${value}" - ${config.description}`);
+      errors.push(
+        `Invalid value for ${key}: "${value}" - ${config.description}`
+      );
     }
-    
+
     // Check for warnings
     if (config.warn) {
       const warning = config.warn(value, process.env);
@@ -81,7 +92,7 @@ export function validateEnvironment() {
       }
     }
   }
-  
+
   return {
     valid: errors.length === 0,
     errors,
@@ -96,17 +107,17 @@ export function validateEnvironment() {
  */
 export function validateOrExit(exitOnError = true) {
   const result = validateEnvironment();
-  
+
   // Print validation results
   console.log('\n🔍 Environment Validation:');
   console.log(`   NODE_ENV: ${process.env.NODE_ENV || 'not set'}`);
   console.log(`   PORT: ${process.env.PORT || 'not set'}`);
-  
+
   // Show errors
   if (result.errors.length > 0) {
     console.error('\n❌ Environment Validation Errors:');
     result.errors.forEach(error => console.error(`   - ${error}`));
-    
+
     if (result.missing.length > 0) {
       console.error('\n💡 Tip: Create a .env file with these variables:');
       result.missing.forEach(key => {
@@ -114,7 +125,7 @@ export function validateOrExit(exitOnError = true) {
       });
       console.error('\n   See .env.example for reference');
     }
-    
+
     if (exitOnError) {
       console.error('\n❌ Server cannot start due to environment errors\n');
       process.exit(1);
@@ -122,13 +133,13 @@ export function validateOrExit(exitOnError = true) {
   } else {
     console.log('   ✅ All required variables present');
   }
-  
+
   // Show warnings
   if (result.warnings.length > 0) {
     console.warn('\n⚠️  Environment Warnings:');
     result.warnings.forEach(warning => console.warn(`   - ${warning}`));
   }
-  
+
   console.log('');
   return result;
 }
@@ -143,22 +154,29 @@ export function getConfig() {
     port: parseInt(process.env.PORT || '3001'),
     isProduction: process.env.NODE_ENV === 'production',
     isDevelopment: process.env.NODE_ENV === 'development',
-    
+
     // Challonge OAuth
     challonge: {
       clientId: process.env.CHALLONGE_CLIENT_ID,
       clientSecret: process.env.CHALLONGE_CLIENT_SECRET,
       redirectUri: process.env.CHALLONGE_REDIRECT_URI,
-      configured: !!(process.env.CHALLONGE_CLIENT_ID && process.env.CHALLONGE_CLIENT_SECRET)
+      configured: !!(
+        process.env.CHALLONGE_CLIENT_ID && process.env.CHALLONGE_CLIENT_SECRET
+      )
     },
-    
+
     // CORS
     cors: {
-      origin: process.env.NODE_ENV === 'production'
-        ? process.env.FRONTEND_URL
-        : ['http://localhost:5173', 'http://localhost:5174', 'http://localhost:5175']
+      origin:
+        process.env.NODE_ENV === 'production'
+          ? process.env.FRONTEND_URL
+          : [
+              'http://localhost:5173',
+              'http://localhost:5174',
+              'http://localhost:5175'
+            ]
     },
-    
+
     // Security
     session: {
       secret: process.env.SESSION_SECRET || 'dev-secret-change-in-production'