🔄 Refactor scroll logic to improve reliability with virtual scroller rendering retries
This commit is contained in:
@@ -643,31 +643,31 @@ function scrollToResult() {
|
|||||||
if (lineIndex === undefined) return;
|
if (lineIndex === undefined) return;
|
||||||
|
|
||||||
const lineNumber = lineIndex + 1; // Convert to 1-based line number
|
const lineNumber = lineIndex + 1; // Convert to 1-based line number
|
||||||
|
|
||||||
|
// Retry logic for virtual scroller rendering
|
||||||
|
const attemptScroll = (attempt = 0) => {
|
||||||
const lineElement = document.querySelector(`[data-line="${lineNumber}"]`);
|
const lineElement = document.querySelector(`[data-line="${lineNumber}"]`);
|
||||||
|
|
||||||
if (lineElement) {
|
if (lineElement) {
|
||||||
// Scroll to element
|
// Element is rendered, scroll it into view
|
||||||
lineElement.scrollIntoView({ behavior: 'smooth', block: 'center' });
|
lineElement.scrollIntoView({ behavior: 'smooth', block: 'center' });
|
||||||
|
return true;
|
||||||
// For virtual scroller, ensure it's rendered by waiting a tick
|
} else if (attempt < 3) {
|
||||||
if (!lineElement.textContent) {
|
// Virtual scroller may not have rendered yet, try again
|
||||||
setTimeout(() => {
|
setTimeout(() => attemptScroll(attempt + 1), 50);
|
||||||
const retryElement = document.querySelector(
|
return false;
|
||||||
`[data-line="${lineNumber}"]`
|
|
||||||
);
|
|
||||||
retryElement?.scrollIntoView({ behavior: 'smooth', block: 'center' });
|
|
||||||
}, 100);
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
// Fallback: scroll container to approximate position
|
// Fallback: scroll container to approximate position
|
||||||
const container = document.querySelector('.scroller, .lines-container');
|
const container = document.querySelector('.scroller, .lines-container');
|
||||||
if (container) {
|
if (container) {
|
||||||
const estimatedScroll =
|
const estimatedScroll = (lineIndex / displayLines.value.length) * (container.scrollHeight - container.clientHeight);
|
||||||
(lineIndex / displayLines.value.length) *
|
|
||||||
(container.scrollHeight - container.clientHeight);
|
|
||||||
container.scrollTop = estimatedScroll;
|
container.scrollTop = estimatedScroll;
|
||||||
}
|
}
|
||||||
|
return false;
|
||||||
}
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
attemptScroll();
|
||||||
}
|
}
|
||||||
|
|
||||||
function applyHistoryItem(item) {
|
function applyHistoryItem(item) {
|
||||||
|
|||||||
Reference in New Issue
Block a user